cmake : llguidance build parser library only #14608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failed macOS check seems to have nothing to do with this PR. |
ggerganov
approved these changes
Jul 10, 2025
gabe-l-hart
added a commit
to gabe-l-hart/llama.cpp
that referenced
this pull request
Jul 10, 2025
* origin/master: cmake : do not search for curl libraries by ourselves (ggml-org#14613) SYCL: Initial set_rows kernel implementation (ggml-org#14562) llama : minor coding style fix for smollm3 (ggml-org#14605) cmake : bump llguidance version to v1.0.1 (ggml-org#14609) cmake : llguidance build parser library only (ggml-org#14608) cuda : support Falcon-H1 state size for SSM_SCAN (ggml-org#14602) Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LLGuidance repo contains a lot of stuffs, while the parser library we care about (
libllguidance.aandllguidance.h) is only a small portion of it, underparserdirectory as per project README, thus building the whole project when building llama.cpp is unnecessary and a waste of time and compute power. This PR instructs CMake to only build the parser library, which cuts the number of compiled Rust packages from ~300 to 75, and provides a ~40% overall build speed increase.Tested with a GitHub Codespace with 2 vCPUs, 8GB RAM, and llama.cpp b5857 with default CMake config (
cmake . -B build -DLLAMA_LLGUIDANCE=ON && time cmake --build build -j $(nproc)):Before (b5857):
After (this PR):