Skip to content

cuda: fix build warnings in set-rows.cu (unused variable) #14687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2025
Merged

cuda: fix build warnings in set-rows.cu (unused variable) #14687

merged 1 commit into from
Jul 15, 2025

Conversation

yeahdongcn
Copy link
Collaborator

Make sure to read the contributing guidelines before submitting a PR

/ws/ggml/src/ggml-cuda/set-rows.cu:6:42: warning: unused parameter 'src_f' [-Wunused-parameter]
__device__ void set_rows_1(const src_t * src_f, dst_t * dst_f) {}
                                         ^
/ws/ggml/src/ggml-cuda/set-rows.cu:6:57: warning: unused parameter 'dst_f' [-Wunused-parameter]
__device__ void set_rows_1(const src_t * src_f, dst_t * dst_f) {}
                                                        ^
/ws/ggml/src/ggml-cuda/set-rows.cu:27:23: warning: unused parameter 'ne10' [-Wunused-parameter]
        const int64_t ne10, const int64_t ne11, const int64_t ne12, const int64_t ne13,
                      ^
/ws/ggml/src/ggml-cuda/set-rows.cu:27:83: warning: unused parameter 'ne13' [-Wunused-parameter]
        const int64_t ne10, const int64_t ne11, const int64_t ne12, const int64_t ne13,
                                                                                  ^

@yeahdongcn
cuda: fix build warnings in set-rows.cu (unused variable)
45e4923 
Signed-off-by: Xiaodong Ye <xiaodong.ye@mthreads.com>
@yeahdongcn yeahdongcn requested a review from am17an July 15, 2025 05:42
@yeahdongcn yeahdongcn self-assigned this Jul 15, 2025
@github-actions github-actions bot added Nvidia GPU Issues specific to Nvidia GPUs ggml changes relating to the ggml tensor library for machine learning labels Jul 15, 2025
am17an
am17an approved these changes Jul 15, 2025
View reviewed changes
Copy link
Collaborator

@am17an am17an left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a separate build where warnings are treated as errors? I noticed this but it passes the CI so I didn't bother. Thanks for fixing - noted not to leave unused params.

@yeahdongcn
Copy link
Collaborator Author

Is there a separate build where warnings are treated as errors? I noticed this but it passes the CI so I didn't bother. Thanks for fixing - noted not to leave unused params.

Yes, our internal CI for building the MUSA backend enables -Werror.

@yeahdongcn yeahdongcn merged commit cbc68be into ggml-org:master Jul 15, 2025
45 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@am17an am17an am17an approved these changes

Assignees

@yeahdongcn yeahdongcn

Labels
ggml changes relating to the ggml tensor library for machine learning Nvidia GPU Issues specific to Nvidia GPUs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yeahdongcn @am17an