ci : enable bindings java job #3070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit re-enables the job previously name `java` which was disabled in the build.yml file. The motivation for this is that we recently fixed a few issue in the java bindings and it should be possible to build them on windows. Refs: ggml-org#2949 Refs: ggml-org#2781
76b109e to
f172fd0
Compare
danbev
commented
Apr 25, 2025
| @@ -135,6 +135,22 @@ if (NOT TARGET ggml) | |||
| add_library(ggml ALIAS ggml::ggml) | |||
| else() | |||
| add_subdirectory(ggml) | |||
| if(WIN32) | |||
| # The following adds a _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR macro and is a workaround for | |||
There was a problem hiding this comment.
I have some notes gathered while looking into this:
https://github.com/danbev/learning-ai/blob/main/notes/whisper/win-java-bindings-issue.md
There was a problem hiding this comment.
@ggerganov Does this look acceptable as a workaround for this? With this the bindings-java job is able to pass.
There was a problem hiding this comment.
Hm, is this a mutex that we use in ggml?
There was a problem hiding this comment.
Yeah, it seems to come from https://github.com/ggml-org/whisper.cpp/blob/master/ggml/src/ggml-threading.cpp.
There was a problem hiding this comment.
Does it make a difference if this becomes:
static std::mutex ggml_critical_section_mutex;I.e. is this CMake flag still necessary?
There was a problem hiding this comment.
I.e. is this CMake flag still necessary
Unfortunately, just this change still produces the error:
> git diff
warning: in the working copy of 'bindings/javascript/package.json', CRLF will be replaced by LF the next time Git touches it
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 34ef7958..070818e5 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -149,7 +149,7 @@ if (NOT TARGET ggml)
#
# Specifically to whisper.cpp this would cause a crash when using the Java bindings.
# resulting in a Invalid memory access error.
- target_compile_definitions(ggml-base PRIVATE _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR)
+ #target_compile_definitions(ggml-base PRIVATE _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR)
endif()
endif()
# ... otherwise assume ggml is added by a parent CMakeLists.txt
diff --git a/ggml/src/ggml-threading.cpp b/ggml/src/ggml-threading.cpp
index 25a19eed..8f6b2b69 100644
--- a/ggml/src/ggml-threading.cpp
+++ b/ggml/src/ggml-threading.cpp
@@ -1,7 +1,7 @@
#include "ggml-threading.h"
#include <mutex>
-std::mutex ggml_critical_section_mutex;
+static std::mutex ggml_critical_section_mutex;
void ggml_critical_section_start() {
ggml_critical_section_mutex.lock();whisper_init_from_file_with_params_no_state: loading model from '../../models/ggml-tiny.en.bin'
whisper_init_with_params_no_state: use gpu = 1
whisper_init_with_params_no_state: flash attn = 0
whisper_init_with_params_no_state: gpu_device = 0
whisper_init_with_params_no_state: dtw = 0
WhisperCppTest > initializationError FAILED
java.lang.Error: Invalid memory access
at com.sun.jna.Native.invokePointer(Native Method)
at com.sun.jna.Function.invokePointer(Function.java:497)
at com.sun.jna.Function.invoke(Function.java:441)
at com.sun.jna.Function.invoke(Function.java:361)
at com.sun.jna.Library$Handler.invoke(Library.java:270)
at jdk.proxy3/jdk.proxy3.$Proxy12.whisper_init_from_file_with_params(Unknown Source)
at io.github.ggerganov.whispercpp.WhisperCpp.initContextImpl(WhisperCpp.java:63)
at io.github.ggerganov.whispercpp.WhisperCpp.initContext(WhisperCpp.java:39)
at io.github.ggerganov.whispercpp.WhisperCppTest.init(WhisperCppTest.java:28)There was a problem hiding this comment.
Ok, thanks for the detailed investigation. @slaren FYI
ggerganov
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests re-enables the java binding job which has been disabled.