whisper : deprecate WHISPER_CCACHE CMake option #3131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit deprecates the WHISPER_CCACHE CMake option in favor of the GGML_CCACHE option. The motivation for this change is that currently when setting, or not setting WHISPER_CCACHE, the outut message from ggml will be that to enable ccache you need to set GGML_CCACHE which can be confusing. This also seems to be inline with what llama.cpp does which does not have a LLAMA_CCACHE option as far as I know. Resolves: ggml-org#3063
ggerganov
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit deprecates the WHISPER_CCACHE CMake option in favor of the GGML_CCACHE option.
The motivation for this change is that currently when setting, or not setting WHISPER_CCACHE, the outut message from ggml will be that to enable ccache you need to set GGML_CCACHE which can be confusing. This also seems to be inline with what llama.cpp does which does not have a LLAMA_CCACHE option as far as I know.
Resolves: #3063