ci : update windows artifact uploads steps #3192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I cancelled the CI run as removing the .zip file extension will not work as the release job currently depends on the files having this. I'm trying this out on my fork to verify that changing this back will work with a release, and after that I'll update this PR. |
This commit modifies windows-blas which was updated previously to use the zip functionality provided by `actions/upload-artifact`. This turned out to be incorrect and I should not have done that. The reason for zipping the archives first is that otherwise the artifacts when downloaded will be unzipped and just be simple directories. In our case the release task depends on the artifacts having a .zip extension so that those archives are include in the release.
b869dea to
b02d3ca
Compare
|
I've tested this on my fork: https://github.com/danbev/whisper.cpp/releases/tag/danbev-fixed-windows-blas |
ggerganov
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies windows-blas which was updated previously to use
the zip functionality provided by
actions/upload-artifact. This turnedout to be incorrect and I should not have done that. The reason for
zipping the archives first is that otherwise the artifacts when
downloaded will be unzipped and just be simple directories. In our case
the release task depends on the artifacts having a .zip extension so
that those archives are include in the release.