ruby : add cleaning of library names in dependencies #3241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a cleaning step to the library names in the `Dependencies` class of the Ruby bindings. The motivation for this is that with the introduction of a library name alias for ggml in Commit (b933d17 "Add in-build ggml::ggml ALIAS library (ggml/1260)) causes the Makefile generation to break: ```console $ sed -n '165,170p' ext/Makefile CLEANOBJS = $(OBJS) *.bak TARGET_SO_DIR_TIMESTAMP = $(TIMESTAMP_DIR)/.sitearchdir.time $(TARGET_SO): libcommon.a libwhisper.a libggml\n(ggml::ggml).a libggml-cpu.a libggml-base.a libcommon.a libwhisper.a libggml\n(ggml::ggml).a libggml-cpu.a libggml-base.a: cmake-targets cmake-targets: /usr/bin/cmake -S sources -B build -D BUILD_SHARED_LIBS=OFF -D CMAKE_ARCHIVE_OUTPUT_DIRECTORY=/home/danbev/work/ai/whisper.cpp/bindings/ruby/ext -D CMAKE_POSITION_INDEPENDENT_CODE=ON ```
|
@ggerganov This might not be the best fix (my Ruby skills are questionable) but it allows CI to pass (and rake test locally). |
KitaitiMakoto
requested changes
Jun 10, 2025
Apply PR review feedback.
KitaitiMakoto
approved these changes
Jun 10, 2025
bygreencn
added a commit
to bygreencn/whisper.cpp
that referenced
this pull request
Jun 29, 2025
* ggerganov/master: (335 commits) server : add Voice Activity Detection (VAD) support (ggml-org#3246) cli : fix short name conflict for vad options [no ci] (ggml-org#3247) ruby : add .gitignore entries for ext directory (ggml-org#3245) ci : update windows runner to windows-2022 (ggml-org#3242) ruby : add cleaning of library names in dependencies (ggml-org#3241) ggml : fix weak alias win32 (#0) android : fix builds (#0) sync : ggml files : remove old sources (part 2) sync : ggml files : remove old sources talk-llama : sync llama.cpp sync : ggml metal : use less stack memory in FA kernel (llama/14088) ggml-cpu : split arch-specific implementations (llama/13892) cuda : fix device sync on buffer clear (llama/14033) CANN: Simplify the environment variable setting(#13104) sycl: Add reorder to Q6_K mmvq implementation (llama/13885) cuda : fix buffer type check with integrated GPUs (llama/14069) SYCL: Implement few same quantized type copy kernels (llama/13739) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a cleaning step to the library names in the
Dependenciesclass of the Ruby bindings.The motivation for this is that with the introduction of a library name alias for ggml in Commit (b933d17 "Add in-build ggml::ggml ALIAS library (ggml/1260)) causes the Makefile generation to break: