Skip to content

examples : set the C++ standard to C++17 for server #3261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025

Conversation

danbev
Copy link
Member

@danbev danbev commented Jun 17, 2025

This commit updates the server example to use C++17 as the standard.

The motivation for this change is that currently the ci-run ggml-100-mac-m4 is failing when compiling the server example on macOS. The talk-llama example also has this setting so it looks like an alright change to make.

ggml-ci

Refs: https://github.com/ggml-org/ci/tree/results/whisper.cpp/2a/4d6db7d90899aff3d58d70996916968e4e0d27/ggml-100-mac-m4

This commit updates the server example to use C++17 as the standard.

The motivation for this change is that currently the ci-run
`ggml-100-mac-m4` is failing when compiling the server example on
macOS. The `talk-llama` example also has this setting so it looks like
an alright change to make.

ggml-ci

Refs: https://github.com/ggml-org/ci/tree/results/whisper.cpp/2a/4d6db7d90899aff3d58d70996916968e4e0d27/ggml-100-mac-m4
@danbev danbev requested a review from ggerganov June 17, 2025 07:07
@danbev danbev merged commit f3ff80e into master Jun 17, 2025
8 checks passed
@danbev danbev deleted the danbev/server-set-cxx-standard branch June 17, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants