whisper : clear result_all if vad_samples is empty #3262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of adding this check can we simply clear the response after sending it to the user? |
This commit clears the results_all vector no VAD segments are found. The motivation for this is that this would normally be done by `whisper_full_with_state` but when no VAD segments are detected this current implementation does not call that function and hence the vector does not get reset. This can lead to issues in applications like the server example where it will incorrectly process the old results. Resolves: ggml-org#3250
e2f1e63 to
d2551be
Compare
Yes, you are right and I've updated with a commit that now clears |
ggerganov
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit clears the results_all vector no VAD segments are found.
The motivation for this is that this would normally be done by
whisper_full_with_statebut when no VAD segments are detected thiscurrent implementation does not call that function and hence the vector
does not get reset. This can lead to issues in applications like the
server example where it will incorrectly process the old results.
Resolves: #3250