whisper-command: write commands to text file
#3273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whisper-command: write commands to text file
danbev
approved these changes
Jun 23, 2025
ggerganov
approved these changes
Jun 23, 2025
|
@ggerganov I've incorporated your suggestions. |
bygreencn
added a commit
to bygreencn/whisper.cpp
that referenced
this pull request
Jun 29, 2025
* ggerganov/master: (72 commits) ci : use selective copy for musa image (ggml-org#3296) ci: set fail-fast to false in docker.yml (ggml-org#3294) ruby : add Whisper::VERSION (ggml-org#3292) whisper : add version function (ggml-org#3289) ci : add should_release variable (ggml-org#3288) docs : add cmake "-j" flag in README.md (ggml-org#3284) ci : add support for tag-based releases (ggml-org#3287) release : v1.7.6 bench : update benches bench : print system info before ctx check stream : add nullptr check of whisper_context (ggml-org#3283) ci : enable main-cuda build (ggml-org#3282) bindings.java : update java example (ggml-org#3281) coreml : backport CoreML features to macos < 14 (ggml-org#3255) ci : reduce musa image size (ggml-org#3277) whisper : add .gitignore entries for OpenVINO support (ggml-org#3276) command: output commands to text file (ggml-org#3273) ci : add apt-get clean to musa Dockerfile (ggml-org#3275) ruby : specify Apple frameworks explicitly on build (ggml-org#3270) talk-llama : sync llama.cpp ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
whisper-commandhas the-f --file FNAMEoption but does not use it in the program. I added some code to open and write to the file if provided, using similar syntax as inwhisper-stream.