Set ExtensionInstallationFolder #2 #1210
Conversation
Updated `Microsoft.VisualStudio.Sdk.BuildTasks.14.0` to 14.0.215.
To make sure that the extension is always installed to the same directory.
|
Heh, actually no it's not good, you need to set the flag on all build types, not just debug. |
Fixes the build.
e12b3ef to
8e066c1
Compare
|
Fixed! |
| @@ -1,6 +1,6 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | |||
| <Import Project="..\..\packages\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.14.0.23-pre\build\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.props" Condition="'$(VisualStudioVersion)' == '14.0' And Exists('..\..\packages\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.14.0.23-pre\build\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.props')" /> | |||
| <Import Project="..\..\packages\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.14.0.215\build\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.props" Condition="Exists('..\..\packages\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.14.0.215\build\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.props')" /> | |||
There was a problem hiding this comment.
We'll need to keep the $(VisualStudioVersion)' == '14.0', if we want it to work in VS2015 and VS2017.
| @@ -1,7 +1,7 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003" ToolsVersion="14.0"> | |||
| <Import Project="..\..\packages\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.14.0.215\build\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.props" Condition="Exists('..\..\packages\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.14.0.215\build\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.props')" /> | |||
There was a problem hiding this comment.
Again, we need to keep $(VisualStudioVersion)' == '14.0'. 😉
| @@ -15,6 +15,7 @@ | |||
| <OutputPath>..\..\build\$(Configuration)\</OutputPath> | |||
| <VsixType>v3</VsixType> | |||
| <IsProductComponent>false</IsProductComponent> | |||
| <ExtensionInstallationFolder>GitHub Extension for Visual Studio</ExtensionInstallationFolder> | |||
There was a problem hiding this comment.
How about just GitHub? It's in the Extensions folder of Visual Studio after all. 😉
| <Import Project="..\..\packages\Microsoft.VSSDK.BuildTools.15.0.26201\build\Microsoft.VSSDK.BuildTools.targets" Condition="'$(VisualStudioVersion)' == '15.0' And Exists('..\..\packages\Microsoft.VSSDK.BuildTools.15.0.26201\build\Microsoft.VSSDK.BuildTools.targets')" /> | ||
| <Import Project="..\..\packages\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.14.0.215\build\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.targets" Condition="Exists('..\..\packages\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.14.0.215\build\Microsoft.VisualStudio.Sdk.BuildTasks.14.0.targets')" /> |
There was a problem hiding this comment.
More $(VisualStudioVersion)' == '14.0'...
Visual Studio 2015When installed from Visual Studio (F5):
When installed with
When installed with
Visual Studio 2017When installed with
Tried to revert (there's no uninstall option): I'm now stuck on the following when I try to open the Extensions manager:
|
|
I'm going to follow instructions from #1206 to try to unscramble this. Will this happen to anyone who has been auto-updated to the previous version? |
|
I've followed the recovery steps from #1206. When I loaded VS 2017 again I got the following (which is one of our old packages):
When I try opening the
😭 Looks like I hit the wrong hashid: It's working again now. Phew! |
|
When launching from VS 2017 using F5, I get the following: This is an easy fix. I'll push... When it runs, assemblies are loaded form the following locations:
When installed with
It looks like |
To make sure that the extension is always installed to the same directory (VS 2017 only). #990 did this originally but that wasn't merged as I thought that our issue had been resolved without it. Seems it's still needed as it's causing problems with the VS Installer.