Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Don't dispose of repo before task completes #1351

Merged
merged 1 commit into from
Nov 28, 2017

Conversation

jcansdale
Copy link
Collaborator

@jcansdale jcansdale commented Nov 28, 2017

GetLatestPushedSha was sometimes disposing of repo object before task had a chance to run. Create and dispose of Repository object as part of task.

This bug was introduced in #1337.

Fixes #1350

@jcansdale jcansdale requested a review from grokys November 28, 2017 15:19
Copy link
Contributor

@grokys grokys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted!

@jcansdale jcansdale merged commit e13678c into master Nov 28, 2017
@jcansdale jcansdale deleted the fixes/1350-dispose-repo-early branch November 28, 2017 15:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants