This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Refactor comment view models. #1993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renamed `InlineCommentThreadViewModel` -> `PullRequestReviewCommentThreadViewModel` - Moved `PullRequestReviewCommentThreadViewModel` to GitHub.App - Make comment view models MEF creatable - Add `InitializeAsync` methods to initialize them with data.
Codecov Report
@@ Coverage Diff @@
## master #1993 +/- ##
=========================================
Coverage ? 39.16%
=========================================
Files ? 405
Lines ? 17343
Branches ? 2398
=========================================
Hits ? 6793
Misses ? 10016
Partials ? 534
|
jcansdale
suggested changes
Oct 24, 2018
|
|
||
| ////namespace GitHub.InlineReviews.UnitTests.ViewModels | ||
| ////{ | ||
| //// public class NewInlineCommentThreadViewModelTests |
There was a problem hiding this comment.
What is up with these tests? 🙂
There was a problem hiding this comment.
Ah yes! I removed that class. Need to delete this file.
jcansdale
approved these changes
Oct 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The drafts feature (#1994) requires comment view models to be async initializable and available from GitHub.App. This PR continues #1955 to:
InlineCommentThreadViewModel->PullRequestReviewCommentThreadViewModelPullRequestReviewCommentThreadViewModelto GitHub.AppInitializeAsyncmethods to initialize them with data.