Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Use PullRequest.timelineItems instead of PullRequest.timeline #2482

Merged
merged 2 commits into from
Mar 19, 2020

Conversation

jcansdale
Copy link
Collaborator

@jcansdale jcansdale commented Mar 18, 2020

The the deprecated PullRequest.timeline field is going away soon. When it does, this will happen. Convert to using the modern PullRequest.timelineItems field.

Todo

  • Only fetch pull request comments and commits.

How to test

  • Open pull request details view
  • Open pull request timeline page
  • Check that pull request comments and commits appear as expected

Seems to be working...

image

Notes

Thanks @parto, @xuorig, @rmosolgo and @nplasterer for the heads up about this!

Fixes #2481

@jcansdale jcansdale requested a review from a user March 18, 2020 10:42
@rmosolgo
Copy link

Glad it turned out to be a pretty clear substitution 🎉

What's the release turn-around after this PR is merged?

@jcansdale
Copy link
Collaborator Author

@rmosolgo,

What's the release turn-around after this PR is merged?

I'm hoping to get a new version out this week! Hopefully auto-update will work for most users. I know some can get stuck on old versions.

@jcansdale jcansdale merged commit 7884364 into master Mar 19, 2020
@jcansdale jcansdale deleted the fixes/2481-PullRequest.timelineItems branch March 19, 2020 12:02
@rmosolgo
Copy link

@jcansdale, have you cut a new release? Ok to go ahead with the deprecations? (Well, yknow, as ok as ever ?)

@jcansdale
Copy link
Collaborator Author

@rmosolgo sorry about the delay. it has been another crazy week! 😉

I'll try to get a release out today. I'll keep you posted!

@rmosolgo
Copy link

rmosolgo commented Apr 7, 2020

Just checking in about that release -- soon, I need to remove these deprecated schema bits, I'd love for folks to have an upgrade path when that happens!

@jcansdale
Copy link
Collaborator Author

@rmosolgo the updated version is out, but I'm having one hell of a time with Visual Studio's auto-update mechanism. First our certificate expired and now the updated cert doesn't appear to be taking. 😭

@rmosolgo
Copy link

Can you tell if the update has been rolling itself out? Still hoping to move forward with https://github.com/github/ecosystem-api/issues/1876 soon, but if you want to try again, I'll wait!

@jcansdale
Copy link
Collaborator Author

Hi @rmosolgo,

Here's how the rollout is looking.

image

Users updated to the latest version is still depressingly low. I've written to the VS installer folks, but haven't heard back yet. I'll ping them again via Teams. 🤞

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Field 'timeline' doesn't exist on type 'PullRequest'
2 participants