Skip to content

add csp trusted types policy #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Conversation

keithamus
Copy link
Contributor

This adds the setCSPTrustedTypePolicy static method to the AutoCompleteElement, allowing userland code to attach a trusted types policy to the element.

This is similar to the work done in github/include-fragment-element#81 by @lgarron.

@keithamus keithamus requested a review from a team as a code owner March 28, 2023 09:45
@keithamus keithamus requested review from rzhade3 and fletchto99 March 28, 2023 09:46
@primer-css
Copy link

👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

  • 🎨 If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
  • If this is a PR that includes changes to an interaction, please include a video recording in the description.
  • ⚠️ If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.

Copy link

@rzhade3 rzhade3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@fletchto99 fletchto99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thanks for proactively updating our libraries to support trusted types.

@lgarron
Copy link

lgarron commented Mar 31, 2023

This is similar to the work done in github/include-fragment-element#81 by @lgarron.

ohai!

Looking pretty good to me, but of course it's in y'allses hands now. 😃

@KyFaSt
Copy link

KyFaSt commented Apr 11, 2023

hi @keithamus thanks for taking initiative on this, is there anything we can do to support you getting this into github/github?

@keithamus keithamus force-pushed the add-csp-trusted-types-policy branch 2 times, most recently from cb00190 to 2b2b7a2 Compare April 21, 2023 13:53
@keithamus keithamus force-pushed the add-csp-trusted-types-policy branch from 2b2b7a2 to f703f29 Compare April 21, 2023 13:55
@keithamus keithamus merged commit ab9a7ba into main Apr 21, 2023
@keithamus keithamus deleted the add-csp-trusted-types-policy branch April 21, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants