Backup and restore custom CA certificates #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lildude
reviewed
Feb 1, 2017
| @@ -45,6 +45,11 @@ if [ "$GHE_VERSION_MAJOR" -ge 2 ]; then | |||
| fi | |||
| fi | |||
|
|
|||
| if ghe-ssh "$host" -- "which ghe-export-ssl-ca-certificates"; then | |||
There was a problem hiding this comment.
I've not tested this, but isn't this going to produce unnecessary output in the backup output? We might want to direct all output to /dev/null to be sure.
There was a problem hiding this comment.
Good catch, that will write the path of that script when found.
rubiojr
approved these changes
Feb 23, 2017
Merged
jeluhu
pushed a commit
that referenced
this pull request
Jun 12, 2023
fixing multiuser conditional argon secret backup
Merged
JoeFranks1993
pushed a commit
that referenced
this pull request
Jun 15, 2023
dooleydevin
pushed a commit
that referenced
this pull request
Jul 14, 2023
dooleydevin
pushed a commit
that referenced
this pull request
Jul 21, 2023
fixing multiuser conditional argon secret backup
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using enhancements added in GitHub Enterprise 2.8.0, adds support for the backup and restore of custom CA certificates.
These certificates are only restored if an appliance is unconfigured, or the restore is performed with the
-cflag.Requires GitHub Enterprise 2.8.0 or later.
Fixes https://github.com/github/backup-utils/issues/163
/cc @github/backup-utils for review