Allow CustomElements to be redefined #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koddsson
reviewed
Apr 4, 2022
koddsson
approved these changes
Apr 26, 2022
keithamus
approved these changes
Apr 30, 2022
keithamus
added a commit
to github/relative-time-element
that referenced
this pull request
Nov 22, 2022
This moves the `customeElements.define` calls from each respective element and into the index.js file. This is useful for if we wish to load the components classes without defining the custom element. In addition, this changes the pattern of how we register the custom elements, to allow for HMR, as we did in github/catalyst#197.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to allow CustomElements to be redefined when using an HMR plugin. Most plugins override the
definemethod oncustomElementsto not raise an error on redefinition.Running the
.definecall in atry/catchwill have the same behavior if no HMR plugin is present, but allow the plugin to run if it is