Support dasherizing symbols by using their descriptions #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koddsson
approved these changes
May 6, 2022
| @@ -53,7 +53,7 @@ | |||
| { | |||
| "path": "lib/index.js", | |||
| "import": "{controller, attr, target, targets}", | |||
| "limit": "1.64kb" | |||
| "limit": "1.66kb" | |||
There was a problem hiding this comment.
lol should we just set this to 2kb?
Comment on lines
+8
to
+14
| export const mustDasherize = (str: unknown, type = 'property'): string => { | ||
| const dashed = dasherize(str) | ||
| if (!dashed.includes('-')) { | ||
| throw new DOMException(`${type}: ${String(str)} is not a valid ${type} name`, 'SyntaxError') | ||
| } | ||
| return dashed | ||
| } |
There was a problem hiding this comment.
This isn't used any where? Should this be in some other PR?
There was a problem hiding this comment.
Oh this was a rebase error. 🤷 doesn't do any harm staying here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some groundwork for 2.0: dasherizing Symbols currently fails.
symbol.descriptionreturns the string value of the symbol, we should use that to dasherize Symbols.