Skip to content

Fix up types in tests #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 12, 2022
Merged

Fix up types in tests #232

merged 5 commits into from
May 12, 2022

Conversation

keithamus
Copy link
Contributor

This creates a tsconfig.build.json file for building, and extends the tsconfig.json to include files in test. This allows tsc to type check the test directory to make sure we're using correct types.

This is useful because then our test directory is also testing invocation patterns for things like decorators. It potentially guards us against writing types which are unresolvable (or otherwise ergonomically painful) for userland code.

@keithamus keithamus requested a review from a team as a code owner May 12, 2022 14:07
@keithamus keithamus requested a review from theinterned May 12, 2022 14:07
@keithamus keithamus enabled auto-merge May 12, 2022 14:08
@keithamus keithamus merged commit c7b92ea into main May 12, 2022
@keithamus keithamus deleted the fix-up-types-in-tests branch May 12, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants