Skip to content

rework tests for bind #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2022
Merged

rework tests for bind #234

merged 2 commits into from
May 14, 2022

Conversation

keithamus
Copy link
Contributor

@keithamus keithamus commented May 13, 2022 •
edited
Loading

This refactors the tests for Bind, which will make them a little easier to transition to 2.0 stuff. All the same tests, just cleaner.

@keithamus keithamus requested a review from a team as a code owner May 13, 2022 23:18
@keithamus keithamus requested a review from theinterned May 13, 2022 23:18
@keithamus keithamus enabled auto-merge May 13, 2022 23:18
koddsson
koddsson approved these changes May 14, 2022
View reviewed changes
Copy link
Contributor

@koddsson koddsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@keithamus keithamus merged commit 389bf55 into main May 14, 2022
@keithamus keithamus deleted the rework-tests-for-bind branch May 14, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koddsson koddsson koddsson approved these changes

@theinterned theinterned Awaiting requested review from theinterned theinterned was automatically assigned from github/web-systems-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keithamus @koddsson