Skip to content

Add providable ability #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 17, 2022
Merged

Add providable ability #241

merged 3 commits into from
May 17, 2022

Conversation

keithamus
Copy link
Contributor

@keithamus keithamus commented May 17, 2022

This adds the first of the new "Abilities" - a new feature which will release with v2 of Catalyst.

This ability isn't yet exported in the main package, but can be retrieved via import {providable} from '@github/catalyst/lib/abilities.js'. We'll work on a better way to import them 😉

The documentation will remain hidden for now so as not to confuse developers when reading the guide.

@keithamus keithamus force-pushed the add-providable-ability branch 2 times, most recently from 53eb562 to ce68d63 Compare May 17, 2022 17:54
@keithamus keithamus force-pushed the add-providable-ability branch from ce68d63 to d945ecd Compare May 17, 2022 18:03
@keithamus keithamus marked this pull request as ready for review May 17, 2022 18:07
@keithamus keithamus requested a review from a team as a code owner May 17, 2022 18:07
@keithamus keithamus requested a review from manuelpuyol May 17, 2022 18:07
@keithamus keithamus enabled auto-merge May 17, 2022 18:07
@keithamus keithamus merged commit 679c0b9 into main May 17, 2022
Copy link
Contributor

@koddsson koddsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Comment on lines +59 to +62
{
"path": "lib/abilities.js",
"import": "{providable}",
"limit": "1.1kb"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! This makes sense.

@keithamus keithamus deleted the add-providable-ability branch May 17, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants