Skip to content

refactor attr into attrable #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 24, 2022
Merged

refactor attr into attrable #251

merged 4 commits into from
May 24, 2022

Conversation

keithamus
Copy link
Contributor

This refactors attr into an Ability called attrable. This comes with a bunch of improvements around semantics and handling of attrs, including avoiding using attributeChangedCallback which means it will no longer do surprising things based on the presence of attr tags.

@keithamus keithamus marked this pull request as ready for review May 24, 2022 10:35
@keithamus keithamus requested a review from a team as a code owner May 24, 2022 10:35
@keithamus keithamus merged commit 43267ad into v2 May 24, 2022
@keithamus keithamus deleted the refactor-attr-into-attrable branch May 24, 2022 10:51
@keithamus keithamus mentioned this pull request May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants