Skip to content

wrong urls for prev and next links #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2022

Conversation

robin4a4
Copy link
Contributor

I made a mistake on the previous and next links button PR by forgetting the base url which works in dev mode but not on GitHub Pages. It should be fixed now as I copied from the links on the sidebar (and it still works in local). First OSS bug :)

@robin4a4 robin4a4 requested a review from a team as a code owner August 16, 2022 19:54
@robin4a4 robin4a4 requested a review from theinterned August 16, 2022 19:54
Copy link
Contributor

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! I missed this too when checking it locally.

Thanks for the followup!

@keithamus keithamus merged commit 5a4cf07 into github:main Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants