Skip to content

Separate v2 docs #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 12, 2022
Merged

Separate v2 docs #287

merged 4 commits into from
Oct 12, 2022

Conversation

keithamus
Copy link
Contributor

@keithamus keithamus commented Oct 12, 2022 •
edited
Loading

screenshot of the v2 guide, including the warning

It's getting a little difficult to manage the v2 branch documentation, and as we migrate to v2 and more projects use it, it is becoming more useful to consult the v2 docs on the live site.

As such, this adds a v2 version of the documentation, which gives us the opportunity to view the two docs on the site.

@keithamus keithamus requested review from a team and koddsson as code owners October 12, 2022 13:45
@keithamus keithamus enabled auto-merge October 12, 2022 13:47
@primer-css
Copy link

👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

  • 🎨 If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
  • ⏩ If this is a PR that includes changes to an interaction, please include a video recording in the description.
  • ⚠️ If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.

koddsson
koddsson approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@koddsson koddsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@keithamus keithamus merged commit fdb64cf into main Oct 12, 2022
@keithamus keithamus deleted the separate-v2-docs branch October 12, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koddsson koddsson koddsson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keithamus @primer-css @koddsson