tweak css sidebar to be responsive #292

keithamus · 2022-10-20T15:37:16Z

This tweaks the sidebar to handle different screen sizes a little better, and avoid underscrolling during page scroll.

primer-css · 2022-10-20T15:42:05Z

👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

🎨 If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
⏩ If this is a PR that includes changes to an interaction, please include a video recording in the description.
⚠️ If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.

lukasoppermann · 2022-10-21T08:24:07Z

Seems legit to me, but this is not primer related as far as I can tell. Better if somebody who knows takes a look. Like @koddsson

keithamus · 2022-10-21T08:30:50Z

Catalyst is now within Primer's AOR 😸

lukasoppermann · 2022-10-21T08:38:22Z

Catalyst is now within Primer's AOR 😸

Ups. 🤷

Is there a way to verify it works? There is no preview build, right?

I tried to run npm run build:docs on codespaces but I get an error:

@github/catalyst@1.3.0 build:docs
cd docs && JEKYLL_ENV=production bundle exec jekyll build

sh: 1: bundle: not found

tweak css sidebar to be responsive

9438ebb

keithamus requested review from a team and koddsson as code owners October 20, 2022 15:37

tweak css homepage

6d24bc2

lukasoppermann removed the request for review from a team October 21, 2022 08:23

lukasoppermann requested a review from a team October 21, 2022 08:37

lukasoppermann approved these changes Oct 21, 2022

View reviewed changes

keithamus merged commit 9780268 into main Oct 21, 2022

keithamus deleted the tweak-css-sidebar-to-be-responsive branch October 21, 2022 10:00

Provide feedback