feat: add automated release and labelling #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep. It happened. The |
zkoppert
reviewed
Apr 15, 2024
zkoppert
reviewed
Apr 15, 2024
- [x] introduce PR title conventional commits requirement
- [x] document this in the CONTRIBUTING.md
- [x] add auto labelling workflow and configuration
- Split from release-drafter since they each are enacted at different times
- auto-labeler: PR events
- release-drafter: merge to main
Signed-off-by: jmeridth <jmeridth@gmail.com>
Co-authored-by: Zack Koppert <zkoppert@github.com>
b637224 to
c44d657
Compare
jmeridth
commented
Apr 17, 2024
| run: | | ||
| short-tag=$(echo ${{ steps.release-drafter.outputs.tag_name }} | cut -d. -f1) | ||
| echo "SHORT_TAG=$short-tag" >> $GITHUB_OUTPUT | ||
| create_action_images: |
There was a problem hiding this comment.
@zkoppert this is the new image build and deploy stuff, utilizing the tags generated by release-drafter
Signed-off-by: jmeridth <jmeridth@gmail.com>
3cd024e to
1f1d49b
Compare
zkoppert
reviewed
Apr 17, 2024
| uses: docker/login-action@v3 | ||
| with: | ||
| registry: ${{ env.REGISTRY }} | ||
| username: ${{ github.actor }} |
There was a problem hiding this comment.
Who would github.actor be in this case? github-actions?
zkoppert
approved these changes
Apr 17, 2024
This was referenced Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of github/github-ospo#78
Pull Request
Proposed Changes
packages: writepermissions to actionWe might have a chicken&egg problem where
.github/auto-labeler.ymlhas to be on the default branch before it can be found. I tested this in another personal repo and had that arise.Readiness Checklist
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducingReviewer
bug,documentation,enhancement,infrastructure, orbreaking