Skip to content

Add support for Shadow DOM follow-up #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 5, 2019
Merged

Add support for Shadow DOM follow-up #26

merged 7 commits into from
Nov 5, 2019

Conversation

muan
Copy link
Contributor

@muan muan commented Nov 4, 2019 •
edited
Loading

I wanted to resolve #9, so did some digging on the lint failure. It's been a while since we responded to the PR last so I figured I'd take on doing the rest, instead of prompting the author to update their PR. 😬

  • Upgrade Flow to fix the type error, where shadowRoot does not have getElementById. It was added in facebook/flow@72b6397.
  • Add test for shadowRoot context. Before this patch:
FAILED TESTS:
  clipboard-copy element
    shadow DOM context
      ✖ node
        HeadlessChrome 78.0.3904 (Mac OS X 10.14.6)
      AssertionError: expected 'Target in Document' to equal 'Target in shadowRoot'
          at test.js:216:16

cc @jorgecasar

@muan muan requested a review from a team November 4, 2019 22:58
dgraham
dgraham approved these changes Nov 4, 2019
View reviewed changes
@muan @dgraham
Clarfiy test purpose
356470a 
Co-Authored-By: David Graham <dgraham@github.com>
keithamus
keithamus approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Nice clear tests 👍

@muan muan merged commit 8af435a into master Nov 5, 2019
@muan muan deleted the shadowroot branch November 5, 2019 16:10
@muan muan mentioned this pull request Nov 5, 2019
Closed
@muan muan mentioned this pull request May 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@keithamus keithamus keithamus approved these changes

@dgraham dgraham dgraham approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@muan @keithamus @dgraham @jorgecasar