Skip to content

LGTM.com - false positive #2288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brettz9 opened this issue Nov 10, 2019 · 3 comments
Closed

LGTM.com - false positive #2288

brettz9 opened this issue Nov 10, 2019 · 3 comments
Assignees
@erik-krogh
Labels
false-positive JS

Comments

@brettz9
Copy link

brettz9 commented Nov 10, 2019

Description of the false positive

There is no use of the return value here, so it should not be flagged. It appears that this may be a specific problem with call calls.

URL to the alert on the project page on LGTM.com

https://lgtm.com/projects/g/SVG-Edit/svgedit/?mode=list (though this impacting many of my other projects as well).
@brettz9
Copy link
Author

brettz9 commented Nov 10, 2019

Btw, off topic, but if I can just quickly ask--on my alerts page, I don't know why it says 1/14 errors, 0/220 warnings, etc. etc., even when no filters are applied; I'd expect it to show all alerts there (even if the ones at the top of the list are there because of weighting).

@erik-krogh
Copy link
Contributor

Yes, you are absolutely correct.
The query falsely flags calls where reflection is used (.call()/.apply()).

We are fixing this (#2270), and it should be deployed on LGTM within a few weeks.

@max-schaefer max-schaefer mentioned this issue Nov 11, 2019
Merged
@brettz9 brettz9 closed this as completed Nov 11, 2019
@brettz9 brettz9 reopened this Nov 11, 2019
@erik-krogh erik-krogh mentioned this issue Nov 11, 2019
Merged
@erik-krogh
Copy link
Contributor

The fix has been deployed to LGTM, so the false positives you reported no longer appear.

I'm closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erik-krogh erik-krogh

Labels
false-positive JS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brettz9 @max-schaefer @erik-krogh