Skip to content

Dataflow: Fix implicit reads in taint tracking when FlowStates are used #10360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 9, 2022
Merged

Dataflow: Fix implicit reads in taint tracking when FlowStates are used #10360

merged 4 commits into from
Sep 9, 2022

Conversation

atorralba
Copy link
Contributor

The first commit adds a test that fails because implicit reads weren't allowed in sinks or additional taint steps that used FlowStates.

The second commit fixes the issue.

@atorralba atorralba requested a review from a team as a code owner September 8, 2022 15:28
@atorralba atorralba requested review from a team as code owners September 8, 2022 15:32
MathiasVP
MathiasVP previously approved these changes Sep 8, 2022
View reviewed changes
@atorralba atorralba changed the title Java: Fix implicit reads in taint tracking when FlowStates are used Dataflow: Fix implicit reads in taint tracking when FlowStates are used Sep 8, 2022
@atorralba atorralba requested a review from a team as a code owner September 9, 2022 08:26
@github-actions github-actions bot added the JS label Sep 9, 2022
@atorralba atorralba force-pushed the atorralba/fix-taint-implicit-reads branch from 6f9b856 to 1078cf0 Compare September 9, 2022 08:28
@atorralba atorralba removed the JS label Sep 9, 2022
@atorralba atorralba removed the request for review from a team September 9, 2022 08:29
@atorralba atorralba merged commit 569fad6 into github:main Sep 9, 2022
@atorralba atorralba deleted the atorralba/fix-taint-implicit-reads branch September 9, 2022 12:28
@atorralba atorralba mentioned this pull request Sep 16, 2022
Merged
owen-mc added a commit to owen-mc/codeql that referenced this pull request Nov 29, 2022
@owen-mc
Update shared library files for go to PR github#10360
6db037f 
Merge commit: 569fad6
owen-mc added a commit to owen-mc/codeql that referenced this pull request Nov 29, 2022
@owen-mc
Update shared library files for go to PR github#10360
de9fc06 
Merge commit: 569fad6
owen-mc added a commit to owen-mc/codeql that referenced this pull request Nov 29, 2022
@owen-mc
Update shared library files for go to PR github#10360
e100141 
Merge commit: 569fad6
owen-mc added a commit to owen-mc/codeql that referenced this pull request Nov 29, 2022
@owen-mc
Update shared library files for go to PR github#10360
628230f 
Merge commit: 569fad6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschackmull aschackmull aschackmull approved these changes

@MathiasVP MathiasVP MathiasVP left review comments

Assignees
No one assigned
Labels
C# C++ DataFlow Library documentation Java Python Ruby Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atorralba @MathiasVP @aschackmull @owen-mc