Skip to content

Data flow: Refactor shared library #13901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 7, 2023
Merged

Data flow: Refactor shared library #13901

merged 11 commits into from
Aug 7, 2023

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Aug 7, 2023 •
edited
Loading

  • Move DataFlowImpl(Common).qll into an internal folder.
  • Rename DataFlowParameter to InputSig and move it into DataFlow.qll.
  • Adjust all languages to account for these changes.

@hvitved hvitved force-pushed the dataflow/refactor branch from d884a59 to 34864e1 Compare August 7, 2023 09:35
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Aug 7, 2023
@hvitved hvitved marked this pull request as ready for review August 7, 2023 10:49
@hvitved hvitved requested review from a team as code owners August 7, 2023 10:49
@hvitved hvitved requested a review from aschackmull August 7, 2023 10:50
smowton
smowton approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go 👍

michaelnebel
michaelnebel approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C# 👍

aschackmull
aschackmull approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@aschackmull aschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems like some reasonable cleanup 👍

@hvitved hvitved merged commit 2126ab0 into github:main Aug 7, 2023
@hvitved hvitved deleted the dataflow/refactor branch August 7, 2023 11:23
@jketema jketema mentioned this pull request Aug 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smowton smowton smowton approved these changes

@MathiasVP MathiasVP MathiasVP approved these changes

@michaelnebel michaelnebel michaelnebel approved these changes

@aschackmull aschackmull aschackmull approved these changes

Assignees
No one assigned
Labels
C# C++ DataFlow Library Go Java no-change-note-required This PR does not need a change note Python Ruby Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hvitved @smowton @MathiasVP @michaelnebel @aschackmull