C++: Rewrite cpp/cgi-xss to not use default taint tracking
#14424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add a test that demonstrates that we need to look at inidrect expressions and not direct ones.
94cc372 to
3b777c2
Compare
|
Before we merge this, let me address the |
|
Fixed the barrier. MRVA looks good not changes compared to before the rewrite on the projects that we had identified as either (a) being in the MRVA top 1000 and having a relevant source, or (b) a project that we know had alerts before the rewrite. Will rerun DCA. |
|
DCA looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add a test that demonstrates that we need to look at inidrect expressions and not direct ones.
New attempt at this, now using indirect expressions. MRVA and DCA still don't show anything interesting.