Python: fix nested import stars #1489
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppose the have a package
foo
containingfoo/__init__.py
andfoo/foo.py
wherefoo/__init__.py
contains offrom .foo import *
andfoo/foo.py
containsdef foo(): pass
.Then, when we analyse the code
from foo import *; foo
we get both the modulefoo.foo
and the functionfoo
forfoo
.This PR fixes that so that we only get the function
foo
.