Go: Improve robustness of integration tests #15355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-mc
previously approved these changes
Jan 17, 2024
a72bf24 to
783f006
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the robustness of our integration tests for Go. Concretely, we introduce test-specific
GOPATHs to ensure that, for each test, our autobuilder is able to perform the right steps to independently acquire the dependencies necessary to successfully extract the respective test project.Without this change, tests may accidentally benefit from test orderings in which dependencies that were installed for previous tests persist in the global
GOPATHand thus allow later tests to succeed when they should not.