Java: Add isNotEmpty to NullGuards
#1553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschackmull
approved these changes
Jul 9, 2019
|
Should this have a markdown change note for 1.22, and/or an issue with a change note for 1.21.1? |
|
We don't necessarily include a release note for small tweaks like this, as they are often shadowed by much more significant library changes. This change only affects code that uses a particular library. I'll leave it up to @rneatherway to decide if a release note would be helpful to the customer in question. |
|
I'll be notifying them directly when we carry out the upgrade so I don't think that's necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up at a customer and seems like a fairly small fix. I wouldn't mind adding a test, although I think that would require stubbing, having looked at the other tests for nullness. As there wasn't one for
StringUtils.isBlankI left it out, but happy to do so.