Go: Deal with incorrect toolchain versions #15979
Conversation
6a14e3f to
c74d634
Compare
| workingDir, | ||
| ) | ||
|
|
||
| // Run the command. If something goes wrong, report it to the log and signal failure |
There was a problem hiding this comment.
Consider marking this as "installed" regardless to avoid repeatedly attempting to install the same thing.
There was a problem hiding this comment.
I am not sure about this. It seems like a rare scenario where we would repeatedly attempt to install the same version and that fails for whatever reason.
If I had implemented this set specifically for the new check, then okay, but since the implementation is more general, it might lead to weird results down the line if we want to utilise the set of installed versions for something else and find that in some cases those aren't actually installed.
|
@smowton We already set a custom |
|
seems to work locally for me ( |
...ntegration-tests/all-platforms/go/diagnostics/invalid-toolchain-version/diagnostics.expected
Outdated
Show resolved
Hide resolved
|
@smowton weirdness seems to have been due to the awful I have fixed those bugs and added an integration test. |
Co-authored-by: Owen Mansel-Chan <62447351+owen-mc@users.noreply.github.com>
Co-authored-by: Owen Mansel-Chan <62447351+owen-mc@users.noreply.github.com>
This diagnostic was introduced by #15979. However in the meantime the Go team [has backtracked](golang/go#62278 (comment)) on their decision, which leads to confusing alerts for user (e.g. github/codeql-action#2868). Even using Go toolchains from 1.21 to 1.22 we weren't immediately able to reproduce the problem that this diagnostics was meant to guard against. Therefore it was deemed simpler to just remove it. _En passant_ the `Makefile` now accepts `rtjo` not being set.
Starting in Go 1.21, Go uses a new version format for toolchains which uses the
1.N.Psyntax. This is a problem for our users when theirgo.modfiles only contain agodirective that uses the old version format, e.g.go 1.22.1.22is a valid language version, but not a valid toolchain version. If there is no additionaltoolchaindirective in thego.modfile, thengouses the language version as the toolchain version. In the example,1.22is not a valid toolchain version and certaingocommands, particularly those which try to acquire the toolchain corresponding to that version, fail with an unhelpful error.In this PR, we make two changes to the Go autobuilder:
go.modfiles where the language version is1.21or greater, doesn't use the new toolchain version syntax, and there is no explicittoolchaindirective. We emit a warning-level diagnostic in this case.go versionwithGOTOOLCHAIN=go1.N.P(i.e. the correct representation of the toolchain version) to getgoto install that version and avoid subsequent errors despite the incorrect version format. As an optimisation for repos with a lot ofgo.modfiles, we now keep track of toolchain versions that we know are installed and only do this if we don't yet know that the corresponding version is installed.