Skip to content

C++: Generate int-to-bool conversion instructions in C code #18017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 15 commits into from
Closed

C++: Generate int-to-bool conversion instructions in C code #18017

wants to merge 15 commits into from

Conversation

MathiasVP
Copy link
Contributor

@MathiasVP MathiasVP commented Nov 18, 2024 •
edited
Loading

This fixes the inconsistencies highlighted in #18013 by generating the IR for int-to-bool conversions as part of IR generation. There are three places where we need to do something (based on grep'ing for Opcode::LogicalNot and Opcode::ConditionalBranch):

  • When translating branching points
  • When translating NotExpr
  • When translating ?: with two operands

Commit-by-commit review recommended.

@github-actions github-actions bot added the C++ label Nov 18, 2024
@MathiasVP MathiasVP added the no-change-note-required This PR does not need a change note label Nov 18, 2024
@MathiasVP MathiasVP force-pushed the generate-int-to-bool-conversion-instructions branch 2 times, most recently from 7e13550 to 92ac5f6 Compare November 20, 2024 13:48
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 20, 2024
View reviewed changes
@MathiasVP MathiasVP force-pushed the generate-int-to-bool-conversion-instructions branch from 92ac5f6 to 2dc34c7 Compare November 20, 2024 13:58
@MathiasVP MathiasVP changed the title C++: Generate int-to-bool conversion instruction in C code C++: Generate int-to-bool conversion instructions in C code Nov 20, 2024
@MathiasVP MathiasVP force-pushed the generate-int-to-bool-conversion-instructions branch from 2dc34c7 to c9b478b Compare November 20, 2024 14:55
@MathiasVP MathiasVP force-pushed the generate-int-to-bool-conversion-instructions branch from c9b478b to 9d6deb2 Compare January 10, 2025 21:28
@MathiasVP MathiasVP force-pushed the generate-int-to-bool-conversion-instructions branch 5 times, most recently from 2bccb81 to 182bbba Compare January 13, 2025 15:11
@MathiasVP MathiasVP force-pushed the generate-int-to-bool-conversion-instructions branch from 182bbba to c5da44f Compare January 13, 2025 15:59
@MathiasVP MathiasVP mentioned this pull request Jan 13, 2025
Merged
@MathiasVP
Copy link
Contributor Author

Superseded by #18490

@MathiasVP MathiasVP closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees
No one assigned
Labels
C++ no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MathiasVP