Ruby: Avoid a forced CP. #18927
Open
Ruby: Avoid a forced CP. #18927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the URL part extraction in a Net::HTTP request to avoid a forced CP by extracting the inline logic into a dedicated helper predicate.
- Moved inline URL part extraction to a new helper function
- Added documentation for the helper predicate to clarify its purpose
Comments suppressed due to low confidence (1)
ruby/ql/lib/codeql/ruby/frameworks/http_clients/NetHttp.qll:67
- [nitpick] Consider renaming the variable 'new' to something more descriptive to avoid potential confusion with object instantiation keywords.
new = API::getTopLevelMember("Net").getMember("HTTP").getInstance() and
hvitved
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The disjunction mentions
requeston one side andrequestNodeon the other. This means that the disjunction can't go first and the call the the charpred must be done first. Due to ainline_late bindingset[...]call inside the inlinednew.getReturn(_)we can't start with that inside the disjunct and we therefore must choose a CP. Luckily in most databases the CP ends up small but it messes up the normal CP detection heuristics as all the CPs are weighted equally.