Run pytest server with sudo and higher nice value
#19204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the test server startup command to run with sudo and a higher nice value, aiming to avoid timeouts on macOS-15 runners.
- Added a conditional check for GitHub Actions and POSIX environments.
- Modified the command used to launch the test server.
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
| command = ["python3", "-m", "http.server", "9427", "-b", "localhost"] | ||
| if runs_on.github_actions and runs_on.posix: | ||
| # On GitHub Actions, we try to run the server with higher priority | ||
| command = ["sudo", "nice", "-n", "10"] + command |
There was a problem hiding this comment.
Using sudo in the test command may trigger a password prompt if the runner is not configured for passwordless sudo, potentially causing test hangs. Consider verifying or enforcing passwordless sudo configuration on the target runners.
Suggested change
| command = ["sudo", "nice", "-n", "10"] + command | |
| os.nice(10) |
Copilot uses AI. Check for mistakes.
smowton
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run pytest server with
sudoand highernicevalue to avoid timeouts when running this test inmacos-15runners