Skip to content

Actions: Fix invocation of autobuild PowerShell script #19257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

adityasharad
Copy link
Collaborator

Pass the quoted script path to PowerShell using -File. This ensures the path is treated as a string rather than a command, and correctly handles file paths that contain spaces, unblocking integration tests.

Add logging to autobuild.cmd for easier debugging.

Pass the quoted script path to PowerShell using `-File`.
This ensures the path is treated as a string rather
than a command, and correctly handles file paths
that contain spaces, unblocking integration tests.

Add logging to autobuild.cmd for easier debugging.
@adityasharad adityasharad requested a review from a team as a code owner April 9, 2025 03:01
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • actions/extractor/tools/autobuild.cmd: Language not supported

@github-actions github-actions bot added the Actions Analysis of GitHub Actions label Apr 9, 2025
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is powershell even more cryptic than bash? Or am I just more used to bash?

@adityasharad
Copy link
Collaborator Author

The indirection here of Python -> Java -> CMD/batch -> PowerShell really took a while to track down.
PowerShell is about equally expressive, but like you I am more familiar with Bash, and even less so with CMD.

@adityasharad adityasharad merged commit 29af6f7 into github:main Apr 9, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Actions Analysis of GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants