Skip to content

Java: Add EnumType to SimpleTypeSanitizer #19260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 9, 2025
Merged

Java: Add EnumType to SimpleTypeSanitizer #19260

merged 3 commits into from
Apr 9, 2025

Conversation

smowton
Copy link
Contributor

@smowton smowton commented Apr 9, 2025

For the same reasons as integers and other simple values, enums are probably not useful injection vectors for most purposes.

@Copilot Copilot AI review requested due to automatic review settings April 9, 2025 11:14
@smowton smowton requested a review from a team as a code owner April 9, 2025 11:14
Copilot
Copilot AI reviewed Apr 9, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • java/ql/lib/semmle/code/java/security/Sanitizers.qll: Language not supported

@github-actions github-actions bot added the Java label Apr 9, 2025
aschackmull
aschackmull previously approved these changes Apr 9, 2025
View reviewed changes
@smowton
Copy link
Contributor Author

smowton commented Apr 9, 2025

DCA: 6x FPs removed

michaelnebel
michaelnebel previously approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

michaelnebel
michaelnebel approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smowton smowton merged commit cc379b5 into github:main Apr 9, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igfoo igfoo igfoo left review comments

Copilot code review Copilot Copilot left review comments

@michaelnebel michaelnebel michaelnebel approved these changes

@aschackmull aschackmull aschackmull left review comments

Assignees
No one assigned
Labels
documentation Java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smowton @igfoo @michaelnebel @aschackmull