JS: Add support for make-dir package
#19263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for the "make-dir" package by introducing test cases for its functions and updating the CodeQL model and change notes accordingly.
- Introduces a new Express route in a test file to exercise the make-dir package functionality.
- Adds a CodeQL extension model entry to flag potential path injection via the make-dir package.
- Updates the change notes to document the new support.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| javascript/ql/test/query-tests/Security/CWE-022/TaintedPath/make-dir.js | Adds a test route exercising makeDirectory and makeDirectorySync from the make-dir package |
| javascript/ql/lib/ext/make-dir.model.yml | Introduces a new extension model entry for the make-dir package |
| javascript/ql/lib/change-notes/2025-04-09-make-dir.md | Documents the new support for the make-dir package |
Files not reviewed (1)
- javascript/ql/test/query-tests/Security/CWE-022/TaintedPath/TaintedPath.expected: Language not supported
javascript/ql/test/query-tests/Security/CWE-022/TaintedPath/make-dir.js
Outdated
Show resolved
Hide resolved
asgerf
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following pull-request adds model as data for
make-dirpackage.