Skip to content

Rust: Make SummarizedCallable extend Function instead of string #19268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Rust: Make SummarizedCallable extend Function instead of string #19268

wants to merge 5 commits into from
+638 −2,018

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Apr 10, 2025

No description provided.

@github-actions github-actions bot added the Rust Pull requests that update Rust code label Apr 10, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 10, 2025
View reviewed changes
rust/ql/lib/codeql/rust/dataflow/internal/ModelsAsData.qll Outdated
@@ -114,13 +115,30 @@
)
}

private predicate sdf(CallExprBase call, Function f) {

Check warning

Code scanning / CodeQL

Dead code

This code is never used, and it's not publicly exported.
rust/ql/lib/codeql/rust/dataflow/internal/ModelsAsData.qll Outdated
f = call.getStaticTarget()
}

private predicate sdf2(CallExprBase call) {

Check warning

Code scanning / CodeQL

Dead code

This code is never used, and it's not publicly exported.
rust/ql/lib/codeql/rust/internal/TypeInference.qll Outdated
@@ -1017,3 +1017,26 @@
* Gets a type that `n` infers to, if any.
*/
Type inferType(AstNode n) { result = inferType(n, TypePath::nil()) }

/** Provides predicates for debugging the type inference implementation. */
private module Debug {

Check warning

Code scanning / CodeQL

Dead code

This code is never used, and it's not publicly exported.
rust/ql/lib/codeql/rust/internal/TypeInference.qll Outdated
/** Provides predicates for debugging the type inference implementation. */
private module Debug {
private Locatable getRelevantLocatable() {
exists(string filepath, int startline, int startcolumn, int endline, int endcolumn |

Check warning

Code scanning / CodeQL

Omittable 'exists' variable

This exists variable can be omitted by using a don't-care expression [in this argument](1).
rust/ql/lib/codeql/rust/internal/TypeInference.qll Outdated
/** Provides predicates for debugging the type inference implementation. */
private module Debug {
private Locatable getRelevantLocatable() {
exists(string filepath, int startline, int startcolumn, int endline, int endcolumn |

Check warning

Code scanning / CodeQL

Omittable 'exists' variable

This exists variable can be omitted by using a don't-care expression [in this argument](1).
rust/ql/lib/codeql/rust/internal/TypeInference.qll Outdated
/** Provides predicates for debugging the type inference implementation. */
private module Debug {
private Locatable getRelevantLocatable() {
exists(string filepath, int startline, int startcolumn, int endline, int endcolumn |

Check warning

Code scanning / CodeQL

Omittable 'exists' variable

This exists variable can be omitted by using a don't-care expression [in this argument](1).
@hvitved hvitved force-pushed the rust/summarized-callable-base branch 3 times, most recently from 86ccc96 to a91cc6b Compare April 29, 2025 08:53
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 29, 2025
View reviewed changes
rust/ql/lib/codeql/rust/internal/PathResolution.qll Outdated
@@ -1214,3 +1243,59 @@
fileImport(m, f)
}
}

private predicate sdfs(ImplItemNode impl) {

Check warning

Code scanning / CodeQL

Dead code

This code is never used, and it's not publicly exported.
rust/ql/lib/codeql/rust/internal/PathResolution.qll Outdated
private import Type
private import TypeInference

private predicate sdf3(

Check warning

Code scanning / CodeQL

Dead code

This code is never used, and it's not publicly exported.
rust/ql/lib/codeql/rust/internal/PathResolution.qll Outdated
f = impl.resolveSelfTy().getASuccessor(name)
}

private predicate sdf4(

Check warning

Code scanning / CodeQL

Dead code

This code is never used, and it's not publicly exported.
rust/ql/lib/codeql/rust/internal/PathResolution.qll Outdated
useResolved = resolvePath(usePathPrefix)
}

private predicate sdf5(ImplItemNode impl, string path, RelevantPath p, ItemNode iter, Module m) {

Check warning

Code scanning / CodeQL

Dead code

This code is never used, and it's not publicly exported.
shared/typeinference/codeql/typeinference/internal/TypeInference.qll Outdated
@@ -474,6 +474,28 @@
module Matching<MatchingInputSig Input> {
private import Input

private predicate testunadjustedAccessType(

Check warning

Code scanning / CodeQL

Dead code

This code is never used, and it's not publicly exported.
shared/typeinference/codeql/typeinference/internal/TypeInference.qll Outdated
// )
}

private predicate testadjustedAccessType(

Check warning

Code scanning / CodeQL

Dead code

This code is never used, and it's not publicly exported.
@hvitved hvitved force-pushed the rust/summarized-callable-base branch 2 times, most recently from 61f14f0 to e08b3b8 Compare April 30, 2025 13:33
@hvitved hvitved force-pushed the rust/summarized-callable-base branch from 969fb1c to d8b7085 Compare May 1, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hvitved