Skip to content

C++: Do not limit second level scopes to the top-level #19269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2025

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Apr 10, 2025

No description provided.

@github-actions github-actions bot added the C++ label Apr 10, 2025
@jketema
Copy link
Contributor Author

jketema commented Apr 10, 2025

DCA shows some lost results (I'll update as I go through them):

@jketema jketema force-pushed the non-second-level-limits branch from 3b5be53 to 9396f0e Compare April 25, 2025 11:11
@jketema jketema marked this pull request as ready for review April 28, 2025 07:09
@jketema jketema requested a review from a team as a code owner April 28, 2025 07:09
@jketema jketema added the no-change-note-required This PR does not need a change note label Apr 28, 2025
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. I want to take a quick look at the DCA results then I expect to approve this...

Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DCA results look like a similar-ish distribution to the QA run. New results look plausible to me. Your assessment seems to imply that the lost results all make sense in that there are flow complexities involving if / switch that may have been affected by these changes. It looks like performance impact doesn't show up on DCA, which is also expected I think as the change affects a minority of projects strongly.

@jketema jketema merged commit c7e4853 into github:main Apr 30, 2025
17 of 18 checks passed
@jketema jketema deleted the non-second-level-limits branch April 30, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants