JS: Added support for fastify.addHook
#19300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Fastify's addHook method to expand CodeQL's query tests for code injection vulnerabilities. Key changes include:
- Introducing test cases for various Fastify hook events using eval on request query parameters.
- Adding a corresponding model extension in fastify.model.yml.
- Updating change notes to document added support for addHook.
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| javascript/ql/test/query-tests/Security/CWE-094/CodeInjection/fastify.js | Adds multiple hook examples that demonstrate code injection scenarios via eval. |
| javascript/ql/lib/ext/fastify.model.yml | Introduces a model extension mapping for the fastify addHook method. |
| javascript/ql/lib/change-notes/2025-04-14-fastify-addhook.md | Documents the minor analysis change for fastify addHook support. |
Files not reviewed (2)
- javascript/ql/test/query-tests/Security/CWE-094/CodeInjection/CodeInjection.expected: Language not supported
- javascript/ql/test/query-tests/Security/CWE-094/CodeInjection/HeuristicSourceCodeInjection.expected: Language not supported
JS: Add isMiddlewareSetup() hook to Routing model
|
Looking at the latest DCA run, it looks like we spuriously mark the return value of |
asgerf
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following pull-request adds support for
fastify'saddHookmethod.