Rust: Remove the noisy models output from the dataflow/local test. #19305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aibaars
approved these changes
Apr 17, 2025
hvitved
reviewed
Apr 22, 2025
| @@ -6,8 +6,6 @@ private predicate provenance(string model) { RustDataFlow::simpleLocalFlowStep(_ | |||
|
|
|||
| private module Tm = TranslateModels<provenance/1>; | |||
There was a problem hiding this comment.
May as well remove this and the provenance predicate.
There was a problem hiding this comment.
Ah, sorry I missed this. Since the PR has been merged I've made a follow-up for this: #19353
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the noisy models output from the
dataflow/localtest. This test appears to be outputting all taint models, which makes it a maintainability nuisance as this is frequently affected by changes unrelated to the test.@hvitved at present this PR fully removes the models output from this test. If we want to keep it, we could change it to be "pretty printed" instead - I'm not sure exactly how to do that though as this is not an inline expectations test.
update: I keep hitting this problem; I think we should just merge this PR as-is, and come back to creating a better test for models later if there's a reason to have one.