Skip to content

Swift: Make file checking in tests more strict #19347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Apr 22, 2025

With Swift 6.1 the extractor will start to extract files outside of the test directory. These files and their elements we do not want to see in our tests.

Test forgotten in #19344

With Swift 6.1 the extractor will start to extract files outside of the test
directory. These files and their elements we do not want to see in our tests.

Test forgotten in github#19344
@github-actions github-actions bot added the Swift label Apr 22, 2025
@jketema jketema marked this pull request as ready for review April 22, 2025 15:04
@Copilot Copilot AI review requested due to automatic review settings April 22, 2025 15:04
@jketema jketema requested a review from a team as a code owner April 22, 2025 15:04
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • swift/ql/test/library-tests/elements/location/location.ql: Language not supported

@jketema jketema merged commit 7ee862a into github:main Apr 22, 2025
16 checks passed
@jketema jketema deleted the swift-files-2 branch April 22, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants