Add query suite integration tests for swift, actions, csharp, go, javascript, ruby, rust #19355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds integration tests for multiple languages (Java, Go, C#, Actions) to validate query suite inclusion with expected internal-repo changes causing test failures.
- Simplified the test logic in Java by replacing file I/O with helper functions.
- Added new integration tests for Go, C#, and Actions that mirror the Java test structure.
Reviewed Changes
Copilot reviewed 28 out of 44 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| java/ql/integration-tests/java/query-suite/test.py | Replaces manual query resolution and file output with helper functions for checking query suites. |
| go/ql/integration-tests/query-suite/test.py | Introduces integration tests for Go query suites using helper functions. |
| csharp/ql/integration-tests/posix/query-suite/test.py | Introduces integration tests for C# query suites using helper functions. |
| actions/ql/integration-tests/query-suite/test.py | Introduces integration tests for Actions query suites using helper functions. |
Files not reviewed (16)
- actions/ql/integration-tests/query-suite/actions-code-quality.qls.expected: Language not supported
- actions/ql/integration-tests/query-suite/actions-code-scanning.qls.expected: Language not supported
- actions/ql/integration-tests/query-suite/actions-security-and-quality.qls.expected: Language not supported
- actions/ql/integration-tests/query-suite/actions-security-extended.qls.expected: Language not supported
- actions/ql/integration-tests/query-suite/not_included_in_qls.expected: Language not supported
- csharp/ql/integration-tests/posix/query-suite/csharp-code-quality.qls.expected: Language not supported
- csharp/ql/integration-tests/posix/query-suite/csharp-code-scanning.qls.expected: Language not supported
- csharp/ql/integration-tests/posix/query-suite/csharp-security-and-quality.qls.expected: Language not supported
- csharp/ql/integration-tests/posix/query-suite/csharp-security-extended.qls.expected: Language not supported
- csharp/ql/integration-tests/posix/query-suite/not_included_in_qls.expected: Language not supported
- go/ql/integration-tests/query-suite/go-code-quality.qls.expected: Language not supported
- go/ql/integration-tests/query-suite/go-code-scanning.qls.expected: Language not supported
- go/ql/integration-tests/query-suite/go-security-and-quality.qls.expected: Language not supported
- go/ql/integration-tests/query-suite/go-security-extended.qls.expected: Language not supported
- go/ql/integration-tests/query-suite/not_included_in_qls.expected: Language not supported
- javascript/ql/integration-tests/query-suite/javascript-code-quality.qls.expected: Language not supported
redsun82
previously approved these changes
Apr 24, 2025
owen-mc
reviewed
Apr 24, 2025
michaelnebel
previously approved these changes
Apr 24, 2025
650f187 to
20f7f1e
Compare
Yes. There are more changes to query suites recently due to the code-quality work that we're doing. I'm also planning on changing the code-quality query suites to not list individual query IDs, and having these tests in place help in not making accidental mistakes. |
20f7f1e to
6c99666
Compare
Co-authored-by: Paolo Tranquilli <redsun82@github.com>
d03cd33 to
998e64b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding integration tests to all languages to check query inclusion in query suites. The tests rely on changes to the internal repo, so integration tests are expected to be failing.