Skip to content

JS: Merge ES6Class to FunctionStyleClass #19356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

JS: Merge ES6Class to FunctionStyleClass #19356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
6a284ee
Merged `ES6Class` into `FunctionStyleClass`
Napalys Apr 23, 2025
c571721
Update Nodes.qll
Napalys Apr 24, 2025
4705d30
Add call graph tests for prototype methods injected on class
Napalys Apr 28, 2025
ee3a3bd
Add support for prototype methods in class instance member resolution
Napalys Apr 28, 2025
4fbf8ca
Added test cases with inheritance
Napalys Apr 29, 2025
a015003
Updated test case to resolve reflected calls
Napalys Apr 29, 2025
0a9a791
Fixed issue where method calls weren't properly resolved when inherit…
Napalys Apr 29, 2025
c8ee8dc
Add test cases to verify correct call graph resolution with various J…
Napalys Apr 29, 2025
e9ee713
Refactor prototype reference retrieval in ClassNode and update expect…
Napalys Apr 29, 2025
7fec3ae
Renamed `FunctionStyleClass` class to `StandardClassNode`
Napalys Apr 29, 2025
fc7520e
Added change note
Napalys Apr 29, 2025
c091743
Removed code duplication
Napalys Apr 30, 2025
7430d0e
Added failing test with method as field
Napalys Apr 30, 2025
9bab593
Fix class instance method detection in constructor receiver
Napalys May 1, 2025
c7d764f
Brought back `FunctionStyleClass` marked as `deprecated`
Napalys May 1, 2025
c430a36
Refactored merge `StandardClassNode` into `ClassNode`
Napalys May 1, 2025
b8be1bc
JS: Avoid duplication with constructor body
asgerf May 2, 2025
30694c1
Removed code duplication
Napalys May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions javascript/ql/lib/change-notes/2025-04-29-combined-es6-func.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: minorAnalysis
---
* Improved analysis for `ES6 classes` mixed with `function prototypes`, leading to more accurate call graph resolution.
2 changes: 1 addition & 1 deletion javascript/ql/lib/semmle/javascript/ApiGraphs.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1236,7 +1236,7 @@ module API {
exists(DataFlow::ClassNode cls | nd = MkClassInstance(cls) |
ref = cls.getAReceiverNode()
or
ref = cls.(DataFlow::ClassNode::FunctionStyleClass).getAPrototypeReference()
ref = cls.(DataFlow::ClassNode).getAPrototypeReference()
)
or
nd = MkUse(ref)
Expand Down
Loading