Rust: Crate graph extraction workarounds #19362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6919095 to
3ce7728
Compare
paldepind
requested changes
Apr 30, 2025
Comment on lines
376
to
379
| exists(TraitItemNode t | | ||
| this = t.getAnAssocItem() and | ||
| not this.fromSource() | ||
| ) |
There was a problem hiding this comment.
What about this?
Suggested change
| exists(TraitItemNode t | | |
| this = t.getAnAssocItem() and | |
| not this.fromSource() | |
| ) | |
| not this.fromSource() and | |
| this = any(TraitItemNode t).getAnAssocItem() |
| ( | ||
| // when a method exists in both source code and in library code, it is because | ||
| // we also extracted the source code as library code, and hence we only want | ||
| // the method from source code |
There was a problem hiding this comment.
Does this not affect path resolution as well? Could the workaround be done in path resolution? Or is there a benefit to having getASuccessor give the duplicated methods?
| super.hasBody() | ||
| or | ||
| // for trait items from library code, we do not currently know if they | ||
| // have default implementations or not, so we assume they do |
There was a problem hiding this comment.
Why do we assume that they have implementations and not the other way around (assume that they don't)?
There was a problem hiding this comment.
That is what we did before, and that meant we were unable to resolve such calls
There was a problem hiding this comment.
Oh, I see. I would've thought that they'd just be prioritized lower in getStaticTarget.
Comment on lines
331
to
334
| exists(TraitItemNode t | | ||
| this = t.getAnAssocItem() and | ||
| not this.fromSource() | ||
| ) |
There was a problem hiding this comment.
What about this?
Suggested change
| exists(TraitItemNode t | | |
| this = t.getAnAssocItem() and | |
| not this.fromSource() | |
| ) | |
| not this.fromSource() and | |
| this = any(TraitItemNode t).getAnAssocItem() |
3ce7728 to
da68329
Compare
da68329 to
52bd99b
Compare
paldepind
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR works around two issues in the crate graph extractor:
core::iter::Iterator(because that's how it is publicly visible), it generatescore::iter::traits::iterator::Iterator, which mentions the privatetraitsmodule.DCA looks great; theMissing call targetsmetric goes down for all projects, without significant analysis slowdown.DCA is somewhat mixed, we both gain and lose call edges; the reason why we lose call edges is that functions extracted from the crate graph don't include constraints, so the
isFullyParametricincorrectly always hold for those.CC: @aibaars