Skip to content

C++: Add exception for build-mode-none in various queries #19368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 24, 2025
Merged

C++: Add exception for build-mode-none in various queries #19368

merged 2 commits into from
Apr 24, 2025

Conversation

igfoo
Copy link
Contributor

@igfoo igfoo commented Apr 24, 2025 •
edited
Loading

This PR introduces checks for the absence of build-mode-none in

  • cpp/wrong-type-format-argument
  • cpp/comparison-with-wider-type
  • cpp/integer-multiplication-cast-to-long
  • cpp/implicit-function-declaration
  • cpp/suspicious-add-sizeof

@igfoo
C++: Add checks for build mode in various queries
063bff0 
Adds a check for the absence of build-mode-none in
    cpp/wrong-type-format-argument
    cpp/comparison-with-wider-type
    cpp/integer-multiplication-cast-to-long
    cpp/implicit-function-declaration
    cpp/suspicious-add-sizeof
@github-actions github-actions bot added the C++ label Apr 24, 2025
@igfoo igfoo marked this pull request as ready for review April 24, 2025 15:44
@Copilot Copilot AI review requested due to automatic review settings April 24, 2025 15:44
@igfoo igfoo requested a review from a team as a code owner April 24, 2025 15:44
Copilot
Copilot AI reviewed Apr 24, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (5)
  • cpp/ql/src/Likely Bugs/Arithmetic/IntMultToLong.ql: Language not supported
  • cpp/ql/src/Likely Bugs/Format/WrongTypeFormatArguments.ql: Language not supported
  • cpp/ql/src/Likely Bugs/Underspecified Functions/ImplicitFunctionDeclaration.ql: Language not supported
  • cpp/ql/src/Security/CWE/CWE-190/ComparisonWithWiderType.ql: Language not supported
  • cpp/ql/src/Security/CWE/CWE-468/SuspiciousAddWithSizeof.ql: Language not supported

@igfoo igfoo added the no-change-note-required This PR does not need a change note label Apr 24, 2025
@igfoo igfoo requested a review from esteffin April 24, 2025 15:45
jketema
jketema reviewed Apr 24, 2025
View reviewed changes
Copy link
Contributor

@jketema jketema left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I would like to see the results of a traced DCA experiment, just to be sure this doesn't mess things up wrt to join-orders there. Happy to start one. Started.

@igfoo igfoo changed the title C++: Add checks for build mode in various queries C++: Add exception for build-mode-none in various queries Apr 24, 2025
jketema
jketema approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@jketema jketema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DCA LGTM.

@igfoo igfoo merged commit f9172ff into github:main Apr 24, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@jketema jketema jketema approved these changes

@esteffin esteffin Awaiting requested review from esteffin

Assignees
No one assigned
Labels
C++ no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igfoo @jketema