Swift: add more debug logs #19384
Merged
Swift: add more debug logs #19384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds additional debug log statements to improve the traceability of the Swift extractor's operation. Key changes include:
- New LOG_DEBUG calls in the Observer class methods (main.cpp) to log function invocation.
- Additional LOG_DEBUG messages in SwiftExtractor.cpp to report module loading and processing activities.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| swift/extractor/main.cpp | Added debug logs in parsedArgs, configuredCompiler, performedCompilation, and markSuccessfullyExtractedFiles methods. |
| swift/extractor/SwiftExtractor.cpp | Added debug logs for module loading count and for decisions to skip or process modules. |
| codeql::extractSwiftFiles(state, compiler); | ||
| codeql::extractSwiftInvocation(state, compiler, invocationTrap); | ||
| codeql::extractExtractLazyDeclarations(state, compiler); | ||
| } | ||
|
|
||
| void markSuccessfullyExtractedFiles() { | ||
| LOG_DEBUG("{}()", __func__); |
There was a problem hiding this comment.
[nitpick] Consider standardizing the log message format across Observer methods. For example, if most methods use "{}(...)", you might adjust this log to match for consistency.
Suggested change
| LOG_DEBUG("{}()", __func__); | |
| LOG_DEBUG("{}(...)", __func__); |
Copilot uses AI. Check for mistakes.
jketema
previously approved these changes
Apr 25, 2025
jketema
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.